Comments on: Testing in Rails: Part 8 - Validations http://www.nullislove.com/2008/01/23/testing-in-rails-part-8-validations/ Code for Coders Thu, 28 Aug 2008 13:52:15 +0000 http://wordpress.org/?v=2.5.1 By: Nicos Picos http://www.nullislove.com/2008/01/23/testing-in-rails-part-8-validations/#comment-1213 Nicos Picos Wed, 16 Jul 2008 15:50:31 +0000 http://www.nullislove.com/2008/01/23/testing-in-rails-part-8-validations/#comment-1213 Man.. really wish I had used helpers for the relationship stuff. Thanks for this tutorial, there is little good stuff on testing out there - and I found this very thorough and well written! Man.. really wish I had used helpers for the relationship stuff. Thanks for this tutorial, there is little good stuff on testing out there - and I found this very thorough and well written!

]]> By: Nicos Picos http://www.nullislove.com/2008/01/23/testing-in-rails-part-8-validations/#comment-1212 Nicos Picos Wed, 16 Jul 2008 15:49:24 +0000 http://www.nullislove.com/2008/01/23/testing-in-rails-part-8-validations/#comment-1212 I recommend for the helper that tests presence_of to use clone objects, because otherwise an error will be thrown in the reference for temp. In your example it works because you are just checking for the presence of literals. I found I was usually testing for the presence of other objects. Here is the edited code I used: # helper method used for validates_presence of def assert_presence_required(object, field) # Test that the initial object is valid assert_valid(object) # Test that it becomes invalid by removing the field temp = object.send(field) # CHANGE = use a clone because otherwise reference to the temp object is lost tempClone = temp.clone object.send("#{field}=", nil) assert_invalid(object) assert(object.errors.invalid?(field), "Expected an error on validation") # CHANGE = set it to the clone now to make object valid again. object.send("#{field}=", tempClone) assert_valid(object) I recommend for the helper that tests presence_of to use clone objects, because otherwise an error will be thrown in the reference for temp. In your example it works because you are just checking for the presence of literals. I found I was usually testing for the presence of other objects. Here is the edited code I used:

# helper method used for validates_presence of
def assert_presence_required(object, field)

# Test that the initial object is valid
assert_valid(object)

# Test that it becomes invalid by removing the field
temp = object.send(field)

# CHANGE = use a clone because otherwise reference to the temp object is lost
tempClone = temp.clone
object.send(”#{field}=”, nil)
assert_invalid(object)
assert(object.errors.invalid?(field), “Expected an error on validation”)

# CHANGE = set it to the clone now to make object valid again.
object.send(”#{field}=”, tempClone)
assert_valid(object)

]]> By: Kevin Skoglund http://www.nullislove.com/2008/01/23/testing-in-rails-part-8-validations/#comment-1211 Kevin Skoglund Wed, 16 Jul 2008 15:47:20 +0000 http://www.nullislove.com/2008/01/23/testing-in-rails-part-8-validations/#comment-1211 There is no reason not to use helpers anytime you are repeating yourself. They make testing a lot easier. I didn't use them through this tutorial because I wanted to make sure that the core concepts were clear. There is no reason not to use helpers anytime you are repeating yourself. They make testing a lot easier. I didn’t use them through this tutorial because I wanted to make sure that the core concepts were clear.

]]> By: Nicos Picos http://www.nullislove.com/2008/01/23/testing-in-rails-part-8-validations/#comment-1210 Nicos Picos Wed, 16 Jul 2008 15:04:23 +0000 http://www.nullislove.com/2008/01/23/testing-in-rails-part-8-validations/#comment-1210 Hey, I was wondering how come you don't use such helper methods for testing relationships. Just spent an entire day writing relationship tests, and would have been a lot easier to just have templates (even for the setup could be nice to have a template that will set up all your fixtures according to parameters). Any reason not to do this? Hey,

I was wondering how come you don’t use such helper methods for testing relationships. Just spent an entire day writing relationship tests, and would have been a lot easier to just have templates (even for the setup could be nice to have a template that will set up all your fixtures according to parameters).

Any reason not to do this?

]]> By: Kevin Skoglund http://www.nullislove.com/2008/01/23/testing-in-rails-part-8-validations/#comment-1089 Kevin Skoglund Tue, 08 Apr 2008 12:59:31 +0000 http://www.nullislove.com/2008/01/23/testing-in-rails-part-8-validations/#comment-1089 Good catch. Thanks, David. Good catch. Thanks, David.

]]> By: David http://www.nullislove.com/2008/01/23/testing-in-rails-part-8-validations/#comment-1088 David Tue, 08 Apr 2008 03:21:45 +0000 http://www.nullislove.com/2008/01/23/testing-in-rails-part-8-validations/#comment-1088 This is great and I can't wait for more, but I think you have a typo in your text for the error in the validates format with regex. The code is right with the $ inside the / but the text shows them swapped. Great series. David This is great and I can’t wait for more, but I think you have a typo in your text for the error in the validates format with regex. The code is right with the $ inside the / but the text shows them swapped. Great series.

David

]]>