Comments on: Testing in Rails: Part 7 – ActiveRecord Relationships http://www.nullislove.com/2008/01/08/testing-in-rails-part-7-activerecord-relationships/ Code for Coders Sat, 31 Dec 2011 17:28:04 +0000 hourly 1 http://wordpress.org/?v=3.1.2 By: Kevin Skoglund http://www.nullislove.com/2008/01/08/testing-in-rails-part-7-activerecord-relationships/comment-page-1/#comment-2419 Kevin Skoglund Mon, 17 May 2010 16:10:28 +0000 http://www.nullislove.com/2008/01/08/testing-in-rails-part-7-activerecord-relationships/#comment-2419 Steve: Did you give sunnyside an explicit ID? Maybe the YAML formatting is off? I believe the current behavior is to use the ID if provided, otherwise to create a hash of the label to use. Here are more details on how it works: http://ryandaigle.com/articles/2007/10/26/what-s-new-in-edge-rails-fixtures-just-got-a-whole-lot-easier Since I wrote this, it has become more common to create fixtures *without* providing an explicit ID and to use the hashed value of the name as the ID instead. But both should still work. Steve: Did you give sunnyside an explicit ID? Maybe the YAML formatting is off? I believe the current behavior is to use the ID if provided, otherwise to create a hash of the label to use.

Here are more details on how it works:
http://ryandaigle.com/articles/2007/10/26/what-s-new-in-edge-rails-fixtures-just-got-a-whole-lot-easier

Since I wrote this, it has become more common to create fixtures *without* providing an explicit ID and to use the hashed value of the name as the ID instead. But both should still work.

]]> By: Steve Dame http://www.nullislove.com/2008/01/08/testing-in-rails-part-7-activerecord-relationships/comment-page-1/#comment-2413 Steve Dame Fri, 14 May 2010 21:01:51 +0000 http://www.nullislove.com/2008/01/08/testing-in-rails-part-7-activerecord-relationships/#comment-2413 This was by far the most useful column I've seen on testing. Thanks very much! The one thing that lingers as confusing for me is that my actual ID generated by rails doesn't seem to match up with a manually hashed value of the symbol. For example, in order to test assert_equal(1, @merlot.winery_id), this fails because my rails version (2.3.5) hashes the name of the YAML row label "sunnyside:" in the wineries.yml fixture and loads that into the database as 350710738. So in order to test this I have to do either the following: assert_equal(350710738, @merlot.winery_id) OR assert_equal(@merlot.winery.id, @merlot.winery_id) If, in IRB, I manually check the value of sunnyside, it is irb> "sunnyside".hash.abs => 528506201 My fixture is definitely using the label sunnyside: ... Do you know if for some reason this version of rails is appending characters to symbols in order to determine the ID values? Seems there is an extra string added or something? This was by far the most useful column I’ve seen on testing. Thanks very much! The one thing that lingers as confusing for me is that my actual ID generated by rails doesn’t seem to match up with a manually hashed value of the symbol.

For example, in order to test assert_equal(1, @merlot.winery_id), this fails because my rails version (2.3.5) hashes the name of the YAML row label “sunnyside:” in the wineries.yml fixture and loads that into the database as 350710738. So in order to test this I have to do either the following:

assert_equal(350710738, @merlot.winery_id) OR
assert_equal(@merlot.winery.id, @merlot.winery_id)

If, in IRB, I manually check the value of sunnyside, it is

irb> “sunnyside”.hash.abs
=> 528506201

My fixture is definitely using the label

sunnyside:
…

Do you know if for some reason this version of rails is appending characters to symbols in order to determine the ID values? Seems there is an extra string added or something?

]]> By: Kevin Skoglund http://www.nullislove.com/2008/01/08/testing-in-rails-part-7-activerecord-relationships/comment-page-1/#comment-2411 Kevin Skoglund Fri, 07 May 2010 16:18:47 +0000 http://www.nullislove.com/2008/01/08/testing-in-rails-part-7-activerecord-relationships/#comment-2411 Steve: All the fixtures are shown, either on this post or in the previous one. Steve: All the fixtures are shown, either on this post or in the previous one.

]]> By: Steve http://www.nullislove.com/2008/01/08/testing-in-rails-part-7-activerecord-relationships/comment-page-1/#comment-2410 Steve Thu, 06 May 2010 20:02:26 +0000 http://www.nullislove.com/2008/01/08/testing-in-rails-part-7-activerecord-relationships/#comment-2410 Very helpful, but could you publish (and/or e-mail me) the contents of your fixtures? I'm still sorting through the confusing of trying out relationship associations from the console vs. in the test scripts. Very helpful, but could you publish (and/or e-mail me) the contents of your fixtures? I’m still sorting through the confusing of trying out relationship associations from the console vs. in the test scripts.

]]> By: Brandon http://www.nullislove.com/2008/01/08/testing-in-rails-part-7-activerecord-relationships/comment-page-1/#comment-2399 Brandon Fri, 09 Apr 2010 18:48:35 +0000 http://www.nullislove.com/2008/01/08/testing-in-rails-part-7-activerecord-relationships/#comment-2399 Your post has been extremely useful at helping me understand the nature of AR associations and how to test them. Thank you!. I recently discovered that the shoulda gem contains macros for testing these associations as well. I highly recommend any readers first use this post to understand the nature of testing the associations and then afterwards check out implementing shoulda so you can do things like: should_have_many :tags, :through => :taggings http://wiki.github.com/thoughtbot/shoulda/usage Your post has been extremely useful at helping me understand the nature of AR associations and how to test them. Thank you!. I recently discovered that the shoulda gem contains macros for testing these associations as well. I highly recommend any readers first use this post to understand the nature of testing the associations and then afterwards check out implementing shoulda so you can do things like:

should_have_many :tags, :through => :taggings

http://wiki.github.com/thoughtbot/shoulda/usage

]]> By: Taylor http://www.nullislove.com/2008/01/08/testing-in-rails-part-7-activerecord-relationships/comment-page-1/#comment-1350 Taylor Thu, 08 Jan 2009 17:07:36 +0000 http://www.nullislove.com/2008/01/08/testing-in-rails-part-7-activerecord-relationships/#comment-1350 This is an excellent post! I'm glad I finally found it. I have only one comment - I would suggest NOT having one big "test_relationships" method, but rather breaking up the tests into, for example, "test_belongs_to_winery" and "test_has_and_belongs_to_many_varietals". This is partly personal style, but there is a good reason behind it too. For one thing, if you have one big method, and the belongs_to test breaks, it precludes the later tests from being run. So one failure can mask another. For another, using smaller methods lets you name them more descriptively. Great post though - thanks! This is an excellent post! I’m glad I finally found it. I have only one comment – I would suggest NOT having one big “test_relationships” method, but rather breaking up the tests into, for example, “test_belongs_to_winery” and “test_has_and_belongs_to_many_varietals”.

This is partly personal style, but there is a good reason behind it too. For one thing, if you have one big method, and the belongs_to test breaks, it precludes the later tests from being run. So one failure can mask another. For another, using smaller methods lets you name them more descriptively.

Great post though – thanks!

]]> By: Marty McGee http://www.nullislove.com/2008/01/08/testing-in-rails-part-7-activerecord-relationships/comment-page-1/#comment-1314 Marty McGee Thu, 27 Nov 2008 15:50:52 +0000 http://www.nullislove.com/2008/01/08/testing-in-rails-part-7-activerecord-relationships/#comment-1314 This is by far the most helpful post about Rails 2+ model relationship testing I have found. And just to keep the ball rolling, I wanted to point out that with Foxy Fixtures in Rails 2+, we don't even need to setup the join table fixtures (in this case, "varietals_wines"). Saves some time and effort and keeps tests running accurately in the future. For instance, with the awesome HABTM relationship test Kevin has shared with us, we can simply omit the varietals_wines.yml fixture and have our wine unit test look this this... class WineTest < ActiveSupport::TestCase # omitted unneeded :varietals_wines fixture fixtures :wines, :wineries, :varietals def setup ... @bordeaux = wines(:bordeaux) end def test_relationships ... # has_and_belongs_to_many :varietals assert_equal(3, @bordeaux.varietals.count) @bordeaux.varietals.each do |var| assert(var.wines.include?(@bordeaux)) end (Varietal.find(:all) - @bordeaux.varietals).each do |var| assert(!var.wines.include?(@bordeaux)) end assert_equal("Cabernet Franc", @bordeaux.varietals.sort_by {|v| v.name}.first.name) end end This is by far the most helpful post about Rails 2+ model relationship testing I have found. And just to keep the ball rolling, I wanted to point out that with Foxy Fixtures in Rails 2+, we don’t even need to setup the join table fixtures (in this case, “varietals_wines”). Saves some time and effort and keeps tests running accurately in the future. For instance, with the awesome HABTM relationship test Kevin has shared with us, we can simply omit the varietals_wines.yml fixture and have our wine unit test look this this…

class WineTest < ActiveSupport::TestCase
# omitted unneeded :varietals_wines fixture
fixtures :wines, :wineries, :varietals

def setup
…
@bordeaux = wines(:bordeaux)
end

def test_relationships
…
# has_and_belongs_to_many :varietals
assert_equal(3, @bordeaux.varietals.count)
@bordeaux.varietals.each do |var|
assert(var.wines.include?(@bordeaux))
end
(Varietal.find(:all) – @bordeaux.varietals).each do |var|
assert(!var.wines.include?(@bordeaux))
end
assert_equal(“Cabernet Franc”, @bordeaux.varietals.sort_by {|v| v.name}.first.name)
end
end

]]> By: Kevin Skoglund http://www.nullislove.com/2008/01/08/testing-in-rails-part-7-activerecord-relationships/comment-page-1/#comment-1231 Kevin Skoglund Mon, 04 Aug 2008 13:48:09 +0000 http://www.nullislove.com/2008/01/08/testing-in-rails-part-7-activerecord-relationships/#comment-1231 @Denis: Yes, that would work too. As long as you understand the difference. In my example, the idea is that I'm testing two things to make sure they are the EXACT value I expect. In your example, the idea is that you don't care what value they have, just that they are equal. If @merlot.winery_id and @merlot.winery.id both have a value of 4 then my tests will fail and yours will pass. The way you decide to write your tests will determine if that distinction makes a difference or not. @Denis: Yes, that would work too. As long as you understand the difference.

In my example, the idea is that I’m testing two things to make sure they are the EXACT value I expect. In your example, the idea is that you don’t care what value they have, just that they are equal. If @merlot.winery_id and @merlot.winery.id both have a value of 4 then my tests will fail and yours will pass.

The way you decide to write your tests will determine if that distinction makes a difference or not.

]]> By: Denis http://www.nullislove.com/2008/01/08/testing-in-rails-part-7-activerecord-relationships/comment-page-1/#comment-1230 Denis Mon, 04 Aug 2008 03:56:33 +0000 http://www.nullislove.com/2008/01/08/testing-in-rails-part-7-activerecord-relationships/#comment-1230 In the first relationship test, you wrote: def test_relationships # belongs_to :winery assert_equal(1, @merlot.winery_id) assert_equal(1, @merlot.winery.id) [...] Could we just write this? def test_relationships # belongs_to :winery assert_equal(@merlot.winery.id, @merlot.winery_id) [...] Thanks Denis In the first relationship test, you wrote:
def test_relationships
# belongs_to :winery
assert_equal(1, @merlot.winery_id)
assert_equal(1, @merlot.winery.id)
[...]

Could we just write this?
def test_relationships
# belongs_to :winery
assert_equal(@merlot.winery.id, @merlot.winery_id)
[...]

Thanks
Denis

]]> By: Improbabilidades http://www.nullislove.com/2008/01/08/testing-in-rails-part-7-activerecord-relationships/comment-page-1/#comment-1064 Improbabilidades Tue, 18 Mar 2008 14:12:37 +0000 http://www.nullislove.com/2008/01/08/testing-in-rails-part-7-activerecord-relationships/#comment-1064 <strong>Testing relationships in Rails...</strong> Ler este artigo em português I've been looking for an elegant way to test relationships using Rais, and think it's interesting how so few people really care about it. Most simply say that it's up to the framework to test it's o... Testing relationships in Rails…

Ler este artigo em português
I’ve been looking for an elegant way to test relationships using Rais, and think it’s interesting how so few people really care about it. Most simply say that it’s up to the framework to test it’s o…

]]>